EdvardM
12/21/2016 - 9:59 AM

checklist.md

checklist.md

Developer checklist

  1. Rebased with current master
  2. There are tests for new feature/bugfix
  3. Tests pass
  4. Changes arm relevant only to the current feature/bugfix[URC]
  5. Does it have proper logging?
  6. Does it use network? what if there's a network error?
  7. Does it write to disk? what if the disk is full?
  8. Have you considered other edge cases, other than "happy paths"? What is the edge case?

Notes

[URC] If there are other small changes like simple refactorings, whitespace, rename vars etc. do those in another branch, forked from current branch