About Cacher
Web App
Download
Sign In
Sign Up
menu
Cacher is the code snippet organizer for pro developers
We empower you and your team to get more done, faster
Learn More
brianmwadime
4/18/2016 - 11:15 AM
share
Share
add_circle_outline
Save
Code Review Checklist for Android (Java Only)
Code Review Checklist for Android (Java Only)
AndroidJavaCodeReview.md
content_copy
file_download
Rendered
Source
My Android Java Code Review Checklist
Is the functionality correct?
Are the classes named suitably?
Are the functions named suitably?
How's the datastructure being used? Is it the correct DS or it needs improvement?
Can the classes be further borken into small classes?
Do we need an interface?
If it contain functions that can be reused later then are there Utils created for them?
Can it use already available Util functions?
Does the large set of input for a function deserve a new bean to be created?
Can we decrease the coupling?
Are all the input arguments being validated?
How will the functionalities affect the performance of the app - time and memory?
Is it absolutely necessary to run it on UI therad or would a background thread suffice?
Are all the fail points handled?
Does it degrade gracefully in case of unknown failures?
Are the app-doing level standards being followed?
Is the correct form of storage being used and is memory available for storage?
* Shared Preference * DB * SD Card * Internal Storage
Are the operations thread safe?
What pieces of the component can be executed in parallel?
Are the layouts suitable for all the screen dimensions?
What classes would become obsolete after this implementation?
clear